Did any other work get done on this that would be worth documenting? Other than simply adding the lines, was anything else done that might help future per tenant setting additions?

@loneil — does simply adding these items result in them being exposed/updateable in Traction, or is there another PR needed there to add these three settings to expose them in the Traction UI?

Thanks!

They will need a UI addition to add the fields on the settings page is all

Should I do a quick PR to add them in Traction?

Did any other work get done on this that would be worth documenting? Other than simply adding the lines, was anything else done that might help future per tenant setting additions?

@loneil — does simply adding these items result in them being exposed/updateable in Traction, or is there another PR needed there to add these three settings to expose them in the Traction UI?

Thanks!

Not for this PR. It would be worthwhile exploring refactoring code to wholesale include parameters and create an exclusion list for those that shouldn't be tenant specific. I'd argue that a refactor of the argparse file should be explored to come up with consistent parameter names, etc.

Should I do a quick PR to add them in Traction?

This would be in an RC right? Maybe would have to just wait until the release that includes it is rolled out anyways?

The failing integration test seems to be a fragile test. The same test failed for my recent draft PR.

Should I do a quick PR to add them in Traction?

This would be in an RC right? Maybe would have to just wait until the release that includes it is rolled out anyways?

Yeah we can file an issue for now and I'll add it as soon as a new version is released

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud